1
general::
Good times and bad times, successes and failures, as in We've had our ups and downs but things are going fairly well now. This term was first recorded in 1659.
American Heritage Idioms
2
general::
Phrase(s): (someone’s) ups and downs
a person’s good fortune and bad fortune. • I’ve had my ups and downs, but in general life has been good to me. • All people have their ups and downs.
McGrawhill's American Idioms And Phrasal Verbs